Skip to content

Sync input_select & select#87255

Merged
frenck merged 4 commits into
devfrom
frenck-2023-0242
Feb 3, 2023
Merged

Sync input_select & select#87255
frenck merged 4 commits into
devfrom
frenck-2023-0242

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Feb 3, 2023

Proposed change

Brings features from input_select and select in sync with each other (to the extent possible). Meaning all services are now the same (with the exception of setting the options, which only applies to the input_select entity).

Resolves: home-assistant/architecture#590

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 3, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (select) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of select can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign select Removes the current integration label and assignees on the issue, add the integration domain after the command.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 3, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (input_select) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of input_select can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign input_select Removes the current integration label and assignees on the issue, add the integration domain after the command.

@frenck frenck marked this pull request as ready for review February 3, 2023 10:52
@frenck frenck requested a review from a team as a code owner February 3, 2023 10:52
@frenck frenck marked this pull request as draft February 3, 2023 10:59
@frenck frenck marked this pull request as ready for review February 3, 2023 13:31
@frenck frenck merged commit 1409b89 into dev Feb 3, 2023
@frenck frenck deleted the frenck-2023-0242 branch February 3, 2023 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 4, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests integration: input_select integration: select noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants